pchintar commented on PR #22697: URL: https://github.com/apache/datafusion/pull/22697#issuecomment-4817818572
Hi @Jefffrey I updated my integer rounding implementation to remove the `i128` conversion in the integer path. Instead, it now performs the rounding using native integer arithmetic through `PrimInt` together with `checked_pow`, while keeping separate signed and unsigned rounding logic so the existing overflow and tie-breaking behavior is preserved. I then reran the function tests, Spark tests, and SQL logic tests, and also manually rechecked the large `Int64`, `UInt64`, overflow, negative-scale, and scale-larger-than-value cases to verify that the output is correct. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
