jayzhan211 commented on code in PR #11849:
URL: https://github.com/apache/datafusion/pull/11849#discussion_r1706240824
##########
datafusion/expr/src/test/function_stub.rs:
##########
@@ -43,15 +43,13 @@ macro_rules! create_func {
/// Singleton instance of [$UDAF], ensures the UDAF is only
created once
/// named STATIC_$(UDAF). For example `STATIC_FirstValue`
#[allow(non_upper_case_globals)]
- static [< STATIC_ $UDAF >]:
std::sync::OnceLock<std::sync::Arc<crate::AggregateUDF>> =
Review Comment:
The reason why we have full path in macro is that we can avoid repeatedly
importing where ever we have macro
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
