mbutrovich commented on PR #4795: URL: https://github.com/apache/datafusion-comet/pull/4795#issuecomment-4877263864
Thanks for the quick fix and revision @Dummk0pf! Are you able to assert in the test collecting `case s: CometSparkToColumnarExec => s` from the executed plan and asserting it's non-empty (there are other tests that do something similar)? I want to make sure we're exercising the expected codepath and prevent future regrssions. Otherwise this is ready to go! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
