gabotechs commented on issue #1612:
URL: 
https://github.com/apache/datafusion-python/issues/1612#issuecomment-4892622148

   > Currently it uses downcasting of executors a lot throughtout the repository
   
   This is right, downcasting is indeed a really nice offering from 
`datafusion` from an API standpoint, and it does help a lot in the codebase, it 
would be a shame to not count on it.
   
   > The current implementation relies on storing data in the config that are 
not string key/value pairs
   
   This is indeed [documented tech 
debt](https://github.com/datafusion-contrib/datafusion-distributed/blob/c814a9cfb0cef96d50a4de7de69366c148979e93/src/distributed_planner/distributed_config.rs#L157-L157),
 there was a solution on the table upstream 
https://github.com/apache/datafusion/pull/18739, but it was not very well 
received and we rolled it back.
   
   I think now this should be trivial to fix though.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to