2010YOUY01 commented on code in PR #23324:
URL: https://github.com/apache/datafusion/pull/23324#discussion_r3542671703
##########
datafusion/physical-plan/src/aggregates/aggregate_hash_table/common.rs:
##########
@@ -171,6 +171,106 @@ impl<AggrMode> AggregateHashTable<AggrMode> {
})
}
+ /// Aggregates one input batch after selecting the mode-specific
accumulator
+ /// operation.
+ ///
+ /// Each aggregation mode chooses a different `aggregate_fn` according to
its
+ /// semantics. For example, partial aggregation takes raw inputs, and
update them
+ /// into stored partial states, so [`GroupsAccumulator::update_batch`] is
used.
+ pub(super) fn aggregate_batch_inner<F>(
Review Comment:
This is a good idea 👍🏼 Updated in
[32691af](https://github.com/apache/datafusion/pull/23324/commits/32691af0c8593694f2a051de3fc8aafed5bd9d90)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
