0lai0 opened a new pull request, #4860:
URL: https://github.com/apache/datafusion-comet/pull/4860
## Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and
enhancements and this helps us generate change logs for our releases. You can
link an issue to this PR using the GitHub syntax. For example `Closes #123`
indicates that this PR will close issue #123.
-->
Closes #3126
Supersedes #3615
## Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in
the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your
changes and offer better suggestions for fixes.
-->
Spark 4.1 introduces `TimeType` and the `hour()` function on a TIME child,
which resolves through `HourExpressionBuilder` to `HoursOfTime`,
`RuntimeReplaceable` whose replacement is `StaticInvoke(DateTimeUtils,
IntegerType, "getHoursOfTime", Seq(child))`.
Without a shim, Comet falls back to the JVM for `hour(TIME ...)` and for
`EXTRACT(HOUR FROM TIME ...)` (which parses to the same `HoursOfTime`).
Note that `HoursOfTime` / `TimeType` do **not** exist in Spark 3.4, 3.5, or
4.0 (see the datetime expression audit), so this only needs to be wired in the
spark-4.1+ shim.
## What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is
sometimes worth providing a summary of the individual changes in this PR.
-->
- spark-4.1+ `CometExprShim`: match
`StaticInvoke(DateTimeUtils,"getHoursOfTime", TimeType)` and rewrite it to
DataFusion's built-in `date_part('hour', time)`. DataFusion's `date_part`
signature already accepts `Time64(Nanosecond)` and returns `Int32`, matching
Spark's `Int` result. No new protobuf variant and no new native code path.
- native planner**: accept `LongVal` with `DataType::Time64(Nanosecond)` so
Spark 4.1 TIME literals (i64 nanoseconds-since-midnight) deserialize into
`ScalarValue::Time64Nanosecond`, matching Arrow's storage exactly.
## How are these changes tested?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are
they covered by existing tests)?
-->
- New SQL file test:
`spark/src/test/resources/sql-tests/expressions/datetime/hour_of_time.sql`
- `./mvnw test -Dsuites="org.apache.comet.CometSqlFileTestSuite
hour_of_time" -Dtest=none`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
