github-actions[bot] commented on PR #23389: URL: https://github.com/apache/datafusion/pull/23389#issuecomment-4915150015
<!-- semver-check-comment --> Thank you for opening this pull request! Reviewer note: [cargo-semver-checks](https://github.com/obi1kenobi/cargo-semver-checks) reported the current version number is not SemVer-compatible with the changes in this pull request (compared against the base branch). <details> <summary>Details</summary> ``` Cloning apache/main Building datafusion v54.0.0 (current) error: running cargo-doc on crate 'datafusion' failed with output: ----- Compiling proc-macro2 v1.0.106 Compiling quote v1.0.46 Compiling unicode-ident v1.0.24 Compiling libc v0.2.186 Checking cfg-if v1.0.4 Compiling shlex v2.0.1 Compiling find-msvc-tools v0.1.9 Compiling autocfg v1.5.1 Checking memchr v2.8.3 Compiling libm v0.2.16 Compiling syn v2.0.118 Compiling num-traits v0.2.19 Compiling version_check v0.9.5 Compiling jobserver v0.1.35 Compiling cc v1.2.66 Checking bytes v1.12.1 Compiling zerocopy v0.8.53 Compiling serde_core v1.0.228 Checking equivalent v1.0.2 Compiling getrandom v0.3.4 Checking allocator-api2 v0.2.21 Checking once_cell v1.21.4 Checking itoa v1.0.18 Checking foldhash v0.2.0 Checking hashbrown v0.17.1 Compiling zmij v1.0.21 Checking num-integer v0.1.46 Checking indexmap v2.14.0 Compiling serde v1.0.228 Compiling serde_json v1.0.150 Checking num-bigint v0.4.8 Checking iana-time-zone v0.1.65 Checking siphasher v1.0.3 Compiling pkg-config v0.3.33 Compiling synstructure v0.13.2 Checking phf_shared v0.12.1 Checking chrono v0.4.45 Compiling ahash v0.8.12 Checking stable_deref_trait v1.2.1 Compiling chrono-tz v0.10.4 Checking phf v0.12.1 Checking num-complex v0.4.6 Compiling zstd-sys v2.0.16+zstd.1.5.7 Checking pin-project-lite v0.2.17 Checking litemap v0.8.2 Checking lexical-util v1.0.7 Checking futures-core v0.3.32 Compiling zerocopy-derive v0.8.53 Compiling serde_derive v1.0.228 Compiling zerofrom-derive v0.1.7 Checking zerofrom v0.1.8 Compiling yoke-derive v0.8.2 Checking arrow-schema v59.1.0 Checking half v2.7.1 Checking arrow-buffer v59.1.0 Checking yoke v0.8.3 Compiling zerovec-derive v0.11.3 Compiling displaydoc v0.2.6 Checking arrow-data v59.1.0 Checking smallvec v1.15.2 Compiling zstd-safe v7.2.4 Checking arrow-array v59.1.0 Checking writeable v0.6.3 Compiling object v0.37.3 Checking zerovec v0.11.6 Checking futures-sink v0.3.32 Checking zerotrie v0.2.4 Compiling icu_properties_data v2.2.0 Compiling icu_normalizer_data v2.2.0 Checking tinystr v0.8.3 Checking potential_utf v0.1.5 Checking icu_locale_core v2.2.0 Checking utf8_iter v1.0.4 Checking icu_provider v2.2.0 Checking icu_collections v2.2.0 Checking arrow-select v59.1.0 Compiling tokio-macros v2.7.0 Compiling crc32fast v1.5.0 Compiling semver v1.0.28 Compiling rustc_version v0.4.1 Checking tokio v1.52.3 Checking futures-channel v0.3.32 Compiling futures-macro v0.3.32 Checking lexical-write-integer v1.0.6 Checking lexical-parse-integer v1.0.6 Checking slab v0.4.12 Checking futures-io v0.3.32 Checking simd-adler32 v0.3.9 Checking futures-task v0.3.32 Checking adler2 v2.0.1 Compiling parking_lot_core v0.9.12 Checking bitflags v2.13.0 Checking miniz_oxide v0.8.9 Compiling ar_archive_writer v0.5.2 Checking futures-util v0.3.32 Checking lexical-parse-float v1.0.6 Checking lexical-write-float v1.0.6 Checking icu_normalizer v2.2.0 Compiling psm v0.1.31 Checking icu_properties v2.2.0 Compiling flatbuffers v25.12.19 Checking aho-corasick v1.1.4 Checking scopeguard v1.2.0 Compiling getrandom v0.4.3 Checking unicode-segmentation v1.13.3 Checking zlib-rs v0.6.5 Checking regex-syntax v0.8.11 Checking unicode-width v0.2.2 Checking ryu v1.0.23 Checking base64 v0.22.1 Checking comfy-table v7.2.2 Checking lock_api v0.4.14 Checking idna_adapter v1.2.2 Checking flate2 v1.1.9 Checking regex-automata v0.4.14 Checking lexical-core v1.0.6 Checking arrow-ord v59.1.0 Compiling stacker v0.1.24 Checking atoi v2.0.0 Compiling thiserror v2.0.18 Compiling snap v1.1.1 Checking twox-hash v2.1.2 Checking either v1.16.0 Checking percent-encoding v2.3.2 Checking alloc-no-stdlib v2.0.4 Checking alloc-stdlib v0.2.4 Checking regex v1.12.4 Checking form_urlencoded v1.2.2 Checking lz4_flex v0.13.1 Checking arrow-cast v59.1.0 Checking idna v1.1.0 Checking futures-executor v0.3.32 Compiling thiserror-impl v2.0.18 Compiling tracing-attributes v0.1.31 Compiling ring v0.17.14 Checking tracing-core v0.1.36 Checking csv-core v0.1.13 Checking same-file v1.0.6 Checking simdutf8 v0.1.5 Compiling paste v1.0.15 Checking tracing v0.1.44 Checking walkdir v2.5.0 Checking csv v1.4.0 Checking futures v0.3.32 Checking url v2.5.8 Checking brotli-decompressor v5.0.3 Checking itertools v0.14.0 Checking parking_lot v0.12.5 Compiling async-trait v0.1.89 Compiling recursive-proc-macro-impl v0.1.1 Checking http v1.4.2 Checking getrandom v0.2.17 Checking log v0.4.33 Checking humantime v2.4.0 Checking untrusted v0.9.0 Checking recursive v0.1.1 Checking brotli v8.0.4 Checking zstd v0.13.3 Checking object_store v0.13.2 Checking arrow-ipc v59.1.0 Checking arrow-csv v59.1.0 Checking arrow-json v59.1.0 Checking uuid v1.23.4 Checking arrow-string v59.1.0 Checking arrow-row v59.1.0 Checking arrow-arith v59.1.0 Compiling sqlparser_derive v0.5.0 Compiling seq-macro v0.3.6 Checking itertools v0.15.0 Checking parquet v59.1.0 Checking arrow v59.1.0 Checking sqlparser v0.62.0 Checking typenum v1.20.1 Checking hex v0.4.3 Compiling pin-project-internal v1.1.13 Compiling generic-array v0.14.7 Checking datafusion-doc v54.0.0 (/home/runner/work/datafusion/datafusion/datafusion/doc) Checking hybrid-array v0.4.13 Checking ppv-lite86 v0.2.21 Checking pin-project v1.1.13 Checking rand_core v0.9.5 Compiling rustix v1.1.4 Compiling crossbeam-utils v0.8.22 Checking foldhash v0.1.5 Checking hashbrown v0.15.5 Checking rand_chacha v0.9.0 Checking fixedbitset v0.5.7 Checking linux-raw-sys v0.12.1 Checking petgraph v0.8.3 Checking rand v0.9.4 Checking block-buffer v0.12.1 Checking crypto-common v0.2.2 Checking tokio-util v0.7.18 Checking fastrand v2.4.1 Checking hashbrown v0.14.5 Checking const-oid v0.10.2 Compiling datafusion-macros v54.0.0 (/home/runner/work/datafusion/datafusion/datafusion/macros) Checking digest v0.11.3 Checking tempfile v3.27.0 Checking crypto-common v0.1.7 Checking block-buffer v0.10.4 Checking dashmap v6.2.1 Compiling blake3 v1.8.5 Checking cpufeatures v0.3.0 Checking subtle v2.6.1 Checking digest v0.10.7 Checking arrayvec v0.7.8 Checking constant_time_eq v0.4.2 Checking arrayref v0.3.9 Checking blake2 v0.10.6 Checking sha2 v0.11.0 Checking md-5 v0.11.0 Compiling liblzma-sys v0.4.7 Checking libbz2-rs-sys v0.2.5 Checking bzip2 v0.6.1 Checking datafusion-common-runtime v54.0.0 (/home/runner/work/datafusion/datafusion/datafusion/common-runtime) Checking compression-core v0.4.32 Checking glob v0.3.3 Compiling bigdecimal v0.4.10 Compiling heck v0.5.0 Checking crc-catalog v2.5.0 Checking crc v3.4.0 Compiling strum_macros v0.28.0 Checking tokio-stream v0.1.18 Checking liblzma v0.4.7 Checking compression-codecs v0.4.38 Checking arrow-avro v59.1.0 Checking async-compression v0.4.42 Checking datafusion-common v54.0.0 (/home/runner/work/datafusion/datafusion/datafusion/common) Checking datafusion-expr-common v54.0.0 (/home/runner/work/datafusion/datafusion/datafusion/expr-common) Checking datafusion-physical-expr-common v54.0.0 (/home/runner/work/datafusion/datafusion/datafusion/physical-expr-common) Checking datafusion-functions-window-common v54.0.0 (/home/runner/work/datafusion/datafusion/datafusion/functions-window-common) Checking datafusion-functions-aggregate-common v54.0.0 (/home/runner/work/datafusion/datafusion/datafusion/functions-aggregate-common) Checking datafusion-expr v54.0.0 (/home/runner/work/datafusion/datafusion/datafusion/expr) Checking datafusion-physical-expr v54.0.0 (/home/runner/work/datafusion/datafusion/datafusion/physical-expr) Checking datafusion-execution v54.0.0 (/home/runner/work/datafusion/datafusion/datafusion/execution) Checking datafusion-functions v54.0.0 (/home/runner/work/datafusion/datafusion/datafusion/functions) Checking datafusion-functions-aggregate v54.0.0 (/home/runner/work/datafusion/datafusion/datafusion/functions-aggregate) Checking datafusion-functions-window v54.0.0 (/home/runner/work/datafusion/datafusion/datafusion/functions-window) Checking datafusion-optimizer v54.0.0 (/home/runner/work/datafusion/datafusion/datafusion/optimizer) Checking datafusion-physical-plan v54.0.0 (/home/runner/work/datafusion/datafusion/datafusion/physical-plan) Checking datafusion-physical-expr-adapter v54.0.0 (/home/runner/work/datafusion/datafusion/datafusion/physical-expr-adapter) Checking datafusion-functions-nested v54.0.0 (/home/runner/work/datafusion/datafusion/datafusion/functions-nested) error[E0560]: struct `SortedSpillFile` has no field named `max_record_batch_memory` --> /home/runner/work/datafusion/datafusion/datafusion/physical-plan/src/aggregates/grouped_hash_stream.rs:1223:21 | 1223 | max_record_batch_memory, | ^^^^^^^^^^^^^^^^^^^^^^^ `SortedSpillFile` does not have this field | = note: all struct fields are already assigned Checking datafusion-sql v54.0.0 (/home/runner/work/datafusion/datafusion/datafusion/sql) For more information about this error, try `rustc --explain E0560`. error: could not compile `datafusion-physical-plan` (lib) due to 1 previous error ----- error: failed to build rustdoc for crate datafusion v54.0.0 note: this is usually due to a compilation error in the crate, and is unlikely to be a bug in cargo-semver-checks note: the following command can be used to reproduce the error: cargo new --lib example && cd example && echo '[workspace]' >> Cargo.toml && cargo add --path /home/runner/work/datafusion/datafusion/datafusion/core --features array_expressions,avro,backtrace,bzip2,compression,crypto_expressions,datafusion-datasource-avro,datafusion-datasource-parquet,datafusion-functions-nested,datafusion-sql,datetime_expressions,default,encoding_expressions,extended_tests,flate2,force_hash_collisions,liblzma,math_expressions,nested_expressions,parquet,parquet_encryption,recursive_protection,regex_expressions,serde,sql,sqlparser,string_expressions,unicode_expressions,zstd && cargo check && cargo doc Building datafusion-physical-plan v54.0.0 (current) Built [ 36.931s] (current) Parsing datafusion-physical-plan v54.0.0 (current) Parsed [ 0.133s] (current) Building datafusion-physical-plan v54.0.0 (baseline) Built [ 37.070s] (baseline) Parsing datafusion-physical-plan v54.0.0 (baseline) Parsed [ 0.131s] (baseline) Checking datafusion-physical-plan v54.0.0 -> v54.0.0 (no change; assume patch) Checked [ 0.626s] 223 checks: 220 pass, 3 fail, 0 warn, 30 skip --- failure constructible_struct_adds_private_field: struct no longer constructible due to new private field --- Description: A struct constructible with a struct literal has a new non-public field. It can no longer be constructed using a struct literal outside of its crate. ref: https://doc.rust-lang.org/reference/expressions/struct-expr.html impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.48.0/src/lints/constructible_struct_adds_private_field.ron Failed in: field SortedSpillFile.max_record_batch_memory_and_row_count in /home/runner/work/datafusion/datafusion/datafusion/physical-plan/src/sorts/streaming_merge.rs:107 --- failure struct_pub_field_missing: pub struct's pub field removed or renamed --- Description: A publicly-visible struct has at least one public field that is no longer available under its prior name. It may have been renamed or removed entirely. ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.48.0/src/lints/struct_pub_field_missing.ron Failed in: field file of struct SortedSpillFile, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/6446decf518f29a21c68c2302ea8df8144d02676/datafusion/physical-plan/src/sorts/streaming_merge.rs:62 field max_record_batch_memory of struct SortedSpillFile, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/6446decf518f29a21c68c2302ea8df8144d02676/datafusion/physical-plan/src/sorts/streaming_merge.rs:65 --- failure struct_pub_field_now_doc_hidden: pub struct field is now #[doc(hidden)] --- Description: A pub field of a pub struct is now marked #[doc(hidden)] and is no longer part of the public API. ref: https://doc.rust-lang.org/rustdoc/write-documentation/the-doc-attribute.html#hidden impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.48.0/src/lints/struct_pub_field_now_doc_hidden.ron Failed in: field SortedSpillFile.file in file /home/runner/work/datafusion/datafusion/datafusion/physical-plan/src/sorts/streaming_merge.rs:103 Summary semver requires new major version: 3 major and 0 minor checks failed Finished [ 75.978s] datafusion-physical-plan error: aborting due to failure to build rustdoc for crate datafusion v54.0.0 ``` </details> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
