kosiew commented on PR #23223: URL: https://github.com/apache/datafusion/pull/23223#issuecomment-4915859551
> Have we ever seen StringView overflow errors? I agree these StringView overflows are much less common than normal Utf8 offset overflow. For StringView, the practical cases are huge individual/incrementally-written values or invalid long-view parts; total array bytes can be split across buffers, so this is not the common “total Utf8 array >2GB” case. I think keeping fallible StringView paths is reasonable because the shared `BulkNullStringArrayBuilder` contract is being made fallible end-to-end. Without this, downstream UDF migrations using `try_append_with` / `try_append_byte_map` would still need local special cases for StringView, or would retain panic paths from the old `expect` calls. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
