0lai0 opened a new pull request, #4864:
URL: https://github.com/apache/datafusion-comet/pull/4864

   ## Which issue does this PR close?
   
   Closes #4770
   
   ## Rationale for this change
   
   `CometCollationSuite` currently lives in the `spark-4.1` test shim, but the 
same tests apply to Spark 4.2+. Moving it to `spark-4.1+` and enabling that 
test shim avoids duplicating the suite per Spark minor version.
   
   ## What changes are included in this PR?
   
   - `spark/pom.xml`: add `src/test/${shims.minorPlusVerSrc}` to the 
`add-test-source` execution so the `spark-4.1+` test shim is compiled.
   - Move `CometCollationSuite.scala` from `spark/src/test/spark-4.1/` to 
`spark/src/test/spark-4.1+/` (content unchanged).
   
   ## How are these changes tested?
   
   ```
   ./mvnw test -Pspark-4.1 -Dtest=none 
-Dsuites=org.apache.spark.sql.CometCollationSuite
   ```
   ```
   ./mvnw compile test-compile -Pspark-4.2 -DskipTests
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to