rluvaton commented on code in PR #23430:
URL: https://github.com/apache/datafusion/pull/23430#discussion_r3554660232
##########
datafusion/substrait/src/physical_plan/producer.rs:
##########
@@ -74,12 +74,10 @@ pub fn to_substrait_rel(
let mut types = vec![];
for field in file_config.file_schema().fields.iter() {
- match to_substrait_type(field.data_type(), field.is_nullable()) {
- Ok(t) => {
- names.push(field.name().clone());
- types.push(t);
- }
- Err(e) => return Err(e),
+ {
+ let t = to_substrait_type(field.data_type(),
field.is_nullable())?;
+ names.push(field.name().clone());
+ types.push(t);
}
Review Comment:
Nit: no need for the double closure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
