andygrove commented on code in PR #4720:
URL: https://github.com/apache/datafusion-comet/pull/4720#discussion_r3554833046
##########
dev/diffs/3.5.8.diff:
##########
@@ -266,7 +266,21 @@ index 6f3090d8908..a0e9309888d 100644
}
// test case for ObjectHashAggregate and SortAggregate
-@@ -793,7 +796,7 @@ class DataFrameAggregateSuite extends QueryTest
+@@ -771,7 +774,12 @@ class DataFrameAggregateSuite extends QueryTest
+ }
+
+ test("SPARK-22223: ObjectHashAggregate should not introduce unnecessary
shuffle") {
+- withSQLConf(SQLConf.USE_OBJECT_HASH_AGG.key -> "true") {
++ withSQLConf(
++ SQLConf.USE_OBJECT_HASH_AGG.key -> "true",
++ // Comet runs collect_list/collect_set natively
(CometHashAggregateExec), so the
++ // ObjectHashAggregateExec this test asserts on is no longer present.
Disable Comet
++ // to preserve the original plan-shape assertions.
++ "spark.comet.enabled" -> "false") {
Review Comment:
Agreed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
