alamb commented on code in PR #23336:
URL: https://github.com/apache/datafusion/pull/23336#discussion_r3562658212
##########
.github/workflows/rust.yml:
##########
@@ -628,47 +628,57 @@ jobs:
run: |
ci/scripts/rust_fmt.sh
- # Coverage job disabled due to
- # https://github.com/apache/datafusion/issues/3678
-
- # coverage:
- # name: coverage
- # runs-on: ubuntu-latest
- # steps:
- # - uses: actions/checkout@v4
- # with:
- # submodules: true
- # - name: Install protobuf compiler
- # shell: bash
- # run: |
- # mkdir -p $HOME/d/protoc
- # cd $HOME/d/protoc
- # export PROTO_ZIP="protoc-21.4-linux-x86_64.zip"
- # curl -LO
https://github.com/protocolbuffers/protobuf/releases/download/v21.4/$PROTO_ZIP
- # unzip $PROTO_ZIP
- # export PATH=$PATH:$HOME/d/protoc/bin
- # protoc --version
- # - name: Setup Rust toolchain
- # run: |
- # rustup toolchain install stable
- # rustup default stable
- # rustup component add rustfmt clippy
- # - name: Cache Cargo
- # uses: actions/cache@v4
- # with:
- # path: /home/runner/.cargo
- # # this key is not equal because the user is different than on a
container (runner vs github)
- # key: cargo-coverage-cache3-
- # - name: Run coverage
- # run: |
- # export PATH=$PATH:$HOME/d/protoc/bin
- # rustup toolchain install stable
- # rustup default stable
- # cargo install --version 0.20.1 cargo-tarpaulin
- # cargo tarpaulin --all --out Xml
- # - name: Report coverage
- # continue-on-error: true
- # run: bash <(curl -s https://codecov.io/bash)
+ coverage:
+ name: coverage
+ needs: linux-build-lib
+ runs-on: ${{ vars.USE_RUNS_ON == 'true' &&
format('runs-on={0},family=m8a+m7a+c8a,cpu=16,image=ubuntu24-full-x64,extras=s3-cache,disk=large,tag=datafusion',
github.run_id) || 'ubuntu-latest' }}
Review Comment:
will this consume more of our ASF runner time?
maybe we can try it for a while and make sure it is useful before we spend
too much xtra time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
