andygrove opened a new pull request, #4894:
URL: https://github.com/apache/datafusion-comet/pull/4894

   > This PR was created by an LLM as a draft PR. I will mark it as ready for 
review after human review.
   
   
   ## Which issue does this PR close?
   
   N/A — autonomous exploratory PR.
   
   ## Rationale for this change
   
   Reuse a single CaptureLocations across all rows via captures_read instead of 
allocating a fresh capture buffer per row with captures(), eliminating one heap 
allocation per row in the regexp_extract array path.
   
   ## What changes are included in this PR?
   
   Reuse a single CaptureLocations across all rows via captures_read instead of 
allocating a fresh capture buffer per row with captures(), eliminating one heap 
allocation per row in the regexp_extract array path.
   
   ## How are these changes tested?
   
   Correctness: unit tests + seeded differential fuzz (bit-identical Arrow 
output vs `main`).
   
   Benchmark (criterion):
   
   - spark_regexp_extract_ group 2: 9.362% faster (base 700411ns -> cand 
634838ns)
   - spark_regexp_extract_ group 0: 12.413% faster (base 699389ns -> cand 
612573ns)
   - spark_regexp_extract_ group 1: 10.116% faster (base 682259ns -> cand 
613241ns)
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to