andygrove opened a new pull request, #2073:
URL: https://github.com/apache/datafusion-ballista/pull/2073
# Which issue does this PR close?
N/A - CI-only change, no issue filed.
# Rationale for this change
The TPC-H, TPC-DS, Rust, Docker, and Web TUI workflows are all already gated
on path allowlists, so changes under `docs/**` or to the root `README.md`
correctly skip them. However, those allowlists use whole-directory globs
(`ballista/**`, `benchmarks/**`, `examples/**`, `ballista-cli/**`), and there
are ten markdown files living inside those directories:
```
ballista-cli/README.md
benchmarks/README.md
examples/README.md
ballista/core/README.md
ballista/scheduler/README.md
ballista/executor/README.md
ballista/client/README.md
benchmarks/db-benchmark/README.md
benchmarks/spark/README.md
ballista/scheduler/tests/tpch_plan_stability/README.md
```
As a result, editing only `benchmarks/README.md` currently triggers TPC-H
SF10 and TPC-DS SF1 along with the Rust, Docker, and Web TUI builds. This is
not hypothetical: #2015 ("docs: remove outdated TPC-H benchmark results from
READMEs") touched only `ballista/client/README.md` and ran the full expensive
matrix for no reason.
# What changes are included in this PR?
Appends `- "!**/*.md"` to the `paths` list of both the `push` and
`pull_request` triggers in `tpch.yml`, `tpcds.yml`, `rust.yml`, `docker.yml`,
and `web-tui.yml`. GitHub evaluates path patterns in order and the last match
wins, so the exclusion has to be the final entry.
Two workflows are deliberately left alone:
- `dev.yml` (RAT and prettier) has no path filter and should keep running on
everything, since prettier lints the markdown itself.
- `docs.yaml` still deploys the site on `docs/**`.
Verification, beyond confirming the YAML still parses, simulated the GitHub
path-filter semantics against representative change sets to check both
directions. Docs-only sets now skip all five workflows, while a `.rs` edit, a
`Cargo.toml` bump, and a mixed code-plus-markdown change each still trigger all
five. The mixed case matters most: a PR that touches both code and a README is
not docs-only and must still build.
# Are there any user-facing changes?
No. CI configuration only, with no public API impact.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
