eliot1480 opened a new pull request, #23672: URL: https://github.com/apache/datafusion/pull/23672
## Which issue does this PR close? - Closes #23608 ## Rationale for this change Since the VirtualTables.values field has been deprecated and is soon to be removed in the next substrait update, we should make sure to delete all instances of it to prevent the presence of dead code. ## What changes are included in this PR? Producer now emits VirtualTable.expressions for Values and EmptyRelation, and the consumer now only reads VirtualTable.expressions. Converted 17 direct virtualTable.values entries across 10 JSON test plans to virtualTable.expressions. ## Are these changes tested? Yes they are. Tests ran: ``` cargo check -p datafusion-substrait cargo test -p datafusion-substrait -- test substrait_integration roundtrip_values cargo test -p datafusion-substrait -- test substrait_integration consumer_integration cargo test -p datafusion-substrait -- test substrait_integration builtin_expr_semantics_tests cargo test -p datafusion-substrait -- test substrait_integration non_nullable_lists ``` jq validation for JSON fixtures ## Are there any user-facing changes? No. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
