andygrove commented on code in PR #4948:
URL: https://github.com/apache/datafusion-comet/pull/4948#discussion_r3604049213
##########
spark/src/main/scala/org/apache/comet/serde/predicates.scala:
##########
@@ -257,8 +273,38 @@ object CometInSet extends CometExpressionSerde[InSet] {
}
}
+/**
+ * Mixin for serdes of binary predicates whose native kernel compares raw
bytes: any operand
+ * carrying a non-UTF8_BINARY collation must fall back to Spark, since
byte-wise semantics diverge
+ * from Spark's collation-aware evaluation.
+ */
+trait CollationAwareBinaryPredicate[T <: BinaryExpression] extends
CometExpressionSerde[T] {
+ override def getSupportLevel(expr: T): SupportLevel =
Review Comment:
Would it also make sense to implement `getUnsupportedReasons` so that these
fallback reasons get documented?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
