alamb commented on code in PR #23641:
URL: https://github.com/apache/datafusion/pull/23641#discussion_r3605629213
##########
datafusion/functions/src/datetime/common.rs:
##########
@@ -353,9 +353,9 @@ where
// if the first argument is a scalar utf8 all arguments are expected
to be scalar utf8
ColumnarValue::Scalar(scalar) => match scalar.try_as_str() {
Some(a) => {
- let a = a.as_ref();
- // ASK: Why do we trust `a` to be non-null at this point?
Review Comment:
😆 classic
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
