geoffreyclaude commented on PR #23014: URL: https://github.com/apache/datafusion/pull/23014#issuecomment-5031389699
> Thus if we are going to add this specialization, we should also turn off the IN LIST rewrite @alamb I looked into this a bit more (especially the OR rewrite micro-benchmarks), and I think this should actually be done as a dedicated new PR once the full IN LIST optimization stack has landed. *This* PR is still valuable by itself starting at lists of size 4 (and for dynamic filters), and removing the OR rewrite is not trivial to do (as the gains depend on the data type, eg utf-8 probably still benefits from OR rewrite...) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
