ratmice commented on code in PR #23797:
URL: https://github.com/apache/datafusion/pull/23797#discussion_r3650143910
##########
datafusion-cli/src/exec.rs:
##########
@@ -129,13 +130,15 @@ pub async fn exec_from_files(
pub async fn exec_from_repl(
ctx: &dyn CliSessionContext,
print_options: &mut PrintOptions,
+ history_file: Option<&Path>,
Review Comment:
Good thinking to keep it consistent, we could always add `#[non_exhaustive]`
to both in follow up patch if that is desired.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
