viirya commented on PR #23913: URL: https://github.com/apache/datafusion/pull/23913#issuecomment-5106545810
On the coverage: the uncovered lines were mostly `state()` / `merge_batch()`, which only run under two-phase (Partial → Final) aggregation. The regression queries here are whole-table aggregates that don't trigger that, so those paths showed as uncovered even though the core `update` / `retract` / `evaluate` logic is exercised. I've added a grouped `percentile_cont(DISTINCT ...)` test in #23946 that forces two-phase aggregation (`GROUP BY` with rows repartitioned across partitions — confirmed via EXPLAIN it plans `AggregateExec: mode=Partial` → `RepartitionExec: Hash` → `mode=FinalPartitioned`), so `state()` and `merge_batch()` are now covered. It uses duplicate values within each group, which also verifies the count-map de-dups correctly across the partial-state merge. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
