comphead opened a new pull request, #5079:
URL: https://github.com/apache/datafusion-comet/pull/5079
Mix CodegenDispatchFallback into CometCast so casts that Comet cannot match
Spark bit-for-bit run Spark's own doGenCode inside the Comet pipeline instead
of falling the full projection back to Spark:
- `spark.sql.legacy.castComplexTypesToString.enabled=true` (struct/array/map
to string) is now Incompatible, was Unsupported which forced full fallback.
- Non-CORRECTED `spark.sql.legacy.timeParserPolicy` (LEGACY, EXCEPTION) on
string to date/timestamp casts is now Incompatible.
- Pre-existing Incompatible cases in CometCast (negative-scale decimal to
string, float/double to decimal rounding) also start using the codegen
dispatcher through the mixin.
VariantType casts remain Unsupported and reach the dispatcher too. The mixin
surfaces whatever error Spark itself would emit for Variant. isVariantType is
added to CometTypeShim for the guard.
Tests:
- cast_complex_types_to_string_legacy.sql: drop expect_fallback since these
casts now stay in the Comet pipeline.
- New cast_string_to_date_time_parser_policy_legacy.sql: exercise string to
date/timestamp/timestamp_ntz casts under LEGACY timeParserPolicy.
- CometCastSuite: cast ArrayType(DateType) to unsupported ArrayType now
checks the Comet operator rather than a Spark fallback reason.
## Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and
enhancements and this helps us generate change logs for our releases. You can
link an issue to this PR using the GitHub syntax. For example `Closes #123`
indicates that this PR will close issue #123.
-->
Closes #.
## Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in
the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your
changes and offer better suggestions for fixes.
-->
## What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is
sometimes worth providing a summary of the individual changes in this PR.
-->
## How are these changes tested?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are
they covered by existing tests)?
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
