mbutrovich commented on code in PR #5056:
URL: https://github.com/apache/datafusion-comet/pull/5056#discussion_r3667515259
##########
spark/src/main/java/org/apache/comet/cloud/s3/CometS3CredentialContext.java:
##########
@@ -21,12 +21,15 @@
import java.util.Objects;
+import org.apache.comet.annotation.Public;
+
/**
* Per-request context passed to {@link
* CometS3CredentialProvider#getCredentialsForPath(CometS3CredentialContext)}.
New fields can be
* added here without changing the SPI method signature, so vendors compiled
against earlier
* versions stay binary-compatible.
*/
+@Public
public final class CometS3CredentialContext {
Review Comment:
I have not heard of a use case that we're missing from the current API, and
a couple of vendors have used it successfully AFAIK.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
