2010YOUY01 commented on PR #23951: URL: https://github.com/apache/datafusion/pull/23951#issuecomment-5112488505
Thank you, this looks much better now. It should be good to go after verifying the benchmarks. > @2010YOUY01 can you please run the benchmark that you think are the most appropriate here and review There is no benchmark suite targeting ordered aggregation now, but previously we have found regressions for ordered aggregation with `tcpds`, so I think we could run that. Additionally, I tried a simple query, the performance number is good. ```sql select v1, avg(v1+1) from generate_series(1000000000) as t1(v1) group by v1; ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
