github-actions[bot] commented on PR #24028: URL: https://github.com/apache/datafusion/pull/24028#issuecomment-5143112589
<!-- semver-check-comment --> Thank you for opening this pull request! Reviewer note: [cargo-semver-checks](https://github.com/obi1kenobi/cargo-semver-checks) reported the current version number is not SemVer-compatible with the changes in this pull request (compared against the base branch). <details> <summary>Details</summary> ``` Cloning apache/main Building datafusion-datasource-parquet v54.1.0 (current) Built [ 56.447s] (current) Parsing datafusion-datasource-parquet v54.1.0 (current) Parsed [ 0.032s] (current) Building datafusion-datasource-parquet v54.1.0 (baseline) Built [ 45.502s] (baseline) Parsing datafusion-datasource-parquet v54.1.0 (baseline) Parsed [ 0.032s] (baseline) Checking datafusion-datasource-parquet v54.1.0 -> v54.1.0 (no change; assume patch) Checked [ 0.155s] 223 checks: 223 pass, 30 skip Summary no semver update required Finished [ 103.713s] datafusion-datasource-parquet Building datafusion-ffi v54.1.0 (current) Built [ 62.043s] (current) Parsing datafusion-ffi v54.1.0 (current) Parsed [ 0.064s] (current) Building datafusion-ffi v54.1.0 (baseline) Built [ 60.554s] (baseline) Parsing datafusion-ffi v54.1.0 (baseline) Parsed [ 0.065s] (baseline) Checking datafusion-ffi v54.1.0 -> v54.1.0 (no change; assume patch) Checked [ 0.228s] 223 checks: 221 pass, 1 fail, 1 warn, 30 skip --- failure constructible_struct_adds_field: externally-constructible struct adds field --- Description: A pub struct constructible with a struct literal has a new pub field. Existing struct literals must be updated to include the new field. ref: https://doc.rust-lang.org/reference/expressions/struct-expr.html impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.49.0/src/lints/constructible_struct_adds_field.ron Failed in: field ForeignLibraryModule.create_query_planner in /home/runner/work/datafusion/datafusion/datafusion/ffi/src/tests/mod.rs:122 --- warning repr_c_plain_struct_fields_reordered: struct fields reordered in repr(C) struct --- Description: A public repr(C) struct had its fields reordered. This can change the struct's memory layout, possibly breaking FFI use cases that depend on field position and order. ref: https://doc.rust-lang.org/reference/type-layout.html#reprc-structs impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.49.0/src/lints/repr_c_plain_struct_fields_reordered.ron Failed in: ForeignLibraryModule.version moved from position 19 to 20, in /home/runner/work/datafusion/datafusion/datafusion/ffi/src/tests/mod.rs:127 Summary semver requires new major version: 1 major and 0 minor checks failed Warning produced 1 major and 0 minor level warnings Finished [ 124.255s] datafusion-ffi ``` </details> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
