kosiew commented on code in PR #23906:
URL: https://github.com/apache/datafusion/pull/23906#discussion_r3702754997
##########
datafusion/ffi/tests/ffi_integration.rs:
##########
@@ -95,6 +96,41 @@ mod tests {
Ok(())
}
+ #[tokio::test]
+ async fn test_ffi_table_provider_dml_cross_library() -> Result<()> {
+ let module = get_module()?;
+ let (ctx, codec) = super::utils::ctx_and_codec();
+
+ let ffi_provider = (module.create_table_with_statistics)(codec);
+ let foreign: Arc<dyn TableProvider> = (&ffi_provider).into();
+ let state = ctx.state();
+
+ let delete_plan = foreign
+ .delete_from(
Review Comment:
Nice addition to the integration tests. Could we also add cross-library
DELETE and UPDATE cases with empty filters? The TableProvider contract defines
an empty filter as applying to all rows, so having explicit coverage here would
help lock in the intentionally empty serialized expression representation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
