buraksenn commented on code in PR #23910:
URL: https://github.com/apache/datafusion/pull/23910#discussion_r3712071289
##########
datafusion/physical-expr/src/expressions/binary.rs:
##########
@@ -1307,6 +1354,68 @@ mod tests {
use crate::planner::logical2physical;
use arrow::array::BooleanArray;
use datafusion_expr::col as logical_col;
+
+ #[test]
+ fn test_arithmetic_ordering_overflow() -> Result<()> {
Review Comment:
I've added signed minimum and underflow boundaries which resulted into
finding a gap. Resolved that as well thanks for finding this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
