kumarUjjawal commented on code in PR #23606:
URL: https://github.com/apache/datafusion/pull/23606#discussion_r3720389816
##########
datafusion/execution/src/memory_pool/mod.rs:
##########
@@ -36,6 +37,7 @@ pub mod proxy {
pub use datafusion_common::{
human_readable_count, human_readable_duration, human_readable_size, units,
};
+pub use peak_recording::*;
Review Comment:
Do we need to expose PeakRecordingPool as public API? It seems to be needed
only by benchmarks and this integration test. Could we keep it in the benchmark
utilities and use a small local helper in the test instead? Let me know what
you think.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
