peterxcli commented on PR #5167: URL: https://github.com/apache/datafusion-comet/pull/5167#issuecomment-5205293097
@andygrove thanks for the another round of review. Addressed all required feedback: - Added the `1000000000` rationale in [CometTemporalExpressionSuite.scala](/Users/lixucheng/.codex/worktrees/9842/datafusion-comet/spark/src/test/scala/org/apache/comet/CometTemporalExpressionSuite.scala:61). - Documented the incorrect leap-year message in [datetime.scala](/Users/lixucheng/.codex/worktrees/9842/datafusion-comet/spark/src/main/scala/org/apache/comet/serde/datetime.scala:479). - Updated https://github.com/apache/datafusion-comet/issues/5208 with the reproduction and wrong-message behavior. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
