kumarUjjawal commented on PR #23565: URL: https://github.com/apache/datafusion/pull/23565#issuecomment-5215412029
> Those benchmarks don't actually stress this path at all. In fact I don't think there are any standard benchmarks that will sweat this particular change. There is a `sort_tpch` benchmark but that has a high cardinality `l_comment` string view column, which, once again, doesn't hit this path or show any benefits here. we can compare the repeated-label reproduction with a forced-spill high-cardinality case such as sort-TPCH Q3. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
