timsaucer commented on PR #1674: URL: https://github.com/apache/datafusion-python/pull/1674#issuecomment-5219349114
This is a good start, but if you want to really use these functions then I propose we add a full class wrapper for Limit instead of just the Rust exposed function. That's a bigger change because we currently don't have an expression module but I could see the repo going that way. If that's too large a lift, then maybe we open an issue to track wrapper coverage for all expressions. I'm a bit torn, because as a user I haven't needed access to these parts of the Expressions. @kosiew do you have thoughts on the idea? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
