nam2ee opened a new pull request, #24198:
URL: https://github.com/apache/datafusion/pull/24198

   ## Which issue does this PR close?
   
   - Closes #24197.
   
   ## Rationale for this change
   
   Explained in #24197.
   
   ## What changes are included in this PR?
   
   I just replaced the three feature-gate `panic!`s in 
`datafusion/proto/src/physical_plan/mod.rs` with `not_impl_err!`, following the 
existing `ParquetSink` convention in the same file. Also fixes "a Avro" to "an 
Avro" in the message.
   
   ## Are these changes tested?
   
   Checked the same feature combinations as the `datafusion-proto features` CI 
job and ran `cargo test -p datafusion-proto`. Manually verified with a 
no-default-features build that decoding panicked before and returns 
`NotImplemented` after. No regression test added because the error path only 
exists in feature-disabled builds, which CI only runs `cargo check` on.
   
   ## Are there any user-facing changes?
   
   No API changes.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to