github-actions[bot] commented on PR #24201: URL: https://github.com/apache/datafusion/pull/24201#issuecomment-5230554746
<!-- semver-check-comment --> Thank you for opening this pull request! Reviewer note: [cargo-semver-checks](https://github.com/obi1kenobi/cargo-semver-checks) reported the current version number is not SemVer-compatible with the changes in this pull request (compared against the base branch). <details> <summary>Details</summary> ``` Cloning apache/main Building datafusion-expr v54.1.0 (current) Built [ 28.027s] (current) Parsing datafusion-expr v54.1.0 (current) Parsed [ 0.076s] (current) Building datafusion-expr v54.1.0 (baseline) Built [ 27.890s] (baseline) Parsing datafusion-expr v54.1.0 (baseline) Parsed [ 0.077s] (baseline) Checking datafusion-expr v54.1.0 -> v54.1.0 (no change; assume patch) Checked [ 1.438s] 223 checks: 223 pass, 30 skip Summary no semver update required Finished [ 58.653s] datafusion-expr Building datafusion-expr-common v54.1.0 (current) Built [ 20.368s] (current) Parsing datafusion-expr-common v54.1.0 (current) Parsed [ 0.019s] (current) Building datafusion-expr-common v54.1.0 (baseline) Built [ 20.085s] (baseline) Parsing datafusion-expr-common v54.1.0 (baseline) Parsed [ 0.019s] (baseline) Checking datafusion-expr-common v54.1.0 -> v54.1.0 (no change; assume patch) Checked [ 0.205s] 223 checks: 221 pass, 1 fail, 1 warn, 30 skip --- failure enum_variant_added: enum variant added on exhaustive enum --- Description: A publicly-visible enum without #[non_exhaustive] has a new variant. ref: https://doc.rust-lang.org/cargo/reference/semver.html#enum-variant-new impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.49.0/src/lints/enum_variant_added.ron Failed in: variant TypeSignature:Constrained in /home/runner/work/datafusion/datafusion/datafusion/expr-common/src/signature.rs:175 --- warning partial_ord_enum_variants_reordered: enum variants reordered in #[derive(PartialOrd)] enum --- Description: A public enum that derives PartialOrd had its variants reordered. #[derive(PartialOrd)] uses the enum variant order to set the enum's ordering behavior, so this change may break downstream code that relies on the previous order. ref: https://doc.rust-lang.org/std/cmp/trait.PartialOrd.html#derivable impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.49.0/src/lints/partial_ord_enum_variants_reordered.ron Failed in: TypeSignature::Variadic moved from position 1 to 2, in /home/runner/work/datafusion/datafusion/datafusion/expr-common/src/signature.rs:184 TypeSignature::UserDefined moved from position 2 to 3, in /home/runner/work/datafusion/datafusion/datafusion/expr-common/src/signature.rs:192 TypeSignature::VariadicAny moved from position 3 to 4, in /home/runner/work/datafusion/datafusion/datafusion/expr-common/src/signature.rs:194 TypeSignature::Uniform moved from position 4 to 5, in /home/runner/work/datafusion/datafusion/datafusion/expr-common/src/signature.rs:201 TypeSignature::Exact moved from position 5 to 6, in /home/runner/work/datafusion/datafusion/datafusion/expr-common/src/signature.rs:205 TypeSignature::Coercible moved from position 6 to 7, in /home/runner/work/datafusion/datafusion/datafusion/expr-common/src/signature.rs:213 TypeSignature::Comparable moved from position 7 to 8, in /home/runner/work/datafusion/datafusion/datafusion/expr-common/src/signature.rs:233 TypeSignature::Any moved from position 8 to 9, in /home/runner/work/datafusion/datafusion/datafusion/expr-common/src/signature.rs:237 TypeSignature::OneOf moved from position 9 to 10, in /home/runner/work/datafusion/datafusion/datafusion/expr-common/src/signature.rs:247 TypeSignature::ArraySignature moved from position 10 to 11, in /home/runner/work/datafusion/datafusion/datafusion/expr-common/src/signature.rs:249 TypeSignature::Numeric moved from position 11 to 12, in /home/runner/work/datafusion/datafusion/datafusion/expr-common/src/signature.rs:257 TypeSignature::String moved from position 12 to 13, in /home/runner/work/datafusion/datafusion/datafusion/expr-common/src/signature.rs:268 TypeSignature::Nullary moved from position 13 to 14, in /home/runner/work/datafusion/datafusion/datafusion/expr-common/src/signature.rs:270 Summary semver requires new major version: 1 major and 0 minor checks failed Warning produced 1 major and 0 minor level warnings Finished [ 41.335s] datafusion-expr-common Building datafusion-functions v54.1.0 (current) Built [ 31.549s] (current) Parsing datafusion-functions v54.1.0 (current) Parsed [ 0.087s] (current) Building datafusion-functions v54.1.0 (baseline) Built [ 31.737s] (baseline) Parsing datafusion-functions v54.1.0 (baseline) Parsed [ 0.088s] (baseline) Checking datafusion-functions v54.1.0 -> v54.1.0 (no change; assume patch) Checked [ 0.382s] 223 checks: 223 pass, 30 skip Summary no semver update required Finished [ 65.093s] datafusion-functions Building datafusion-optimizer v54.1.0 (current) Built [ 27.813s] (current) Parsing datafusion-optimizer v54.1.0 (current) Parsed [ 0.031s] (current) Building datafusion-optimizer v54.1.0 (baseline) Built [ 27.664s] (baseline) Parsing datafusion-optimizer v54.1.0 (baseline) Parsed [ 0.032s] (baseline) Checking datafusion-optimizer v54.1.0 -> v54.1.0 (no change; assume patch) Checked [ 0.168s] 223 checks: 223 pass, 30 skip Summary no semver update required Finished [ 56.463s] datafusion-optimizer ``` </details> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
