github-actions[bot] commented on PR #24205: URL: https://github.com/apache/datafusion/pull/24205#issuecomment-5233175569
<!-- semver-check-comment --> Thank you for opening this pull request! Reviewer note: [cargo-semver-checks](https://github.com/obi1kenobi/cargo-semver-checks) reported the current version number is not SemVer-compatible with the changes in this pull request (compared against the base branch). <details> <summary>Details</summary> ``` Cloning apache/main Building datafusion-datasource v54.1.0 (current) Built [ 43.660s] (current) Parsing datafusion-datasource v54.1.0 (current) Parsed [ 0.031s] (current) Building datafusion-datasource v54.1.0 (baseline) Built [ 44.024s] (baseline) Parsing datafusion-datasource v54.1.0 (baseline) Parsed [ 0.032s] (baseline) Checking datafusion-datasource v54.1.0 -> v54.1.0 (no change; assume patch) Checked [ 0.254s] 223 checks: 223 pass, 30 skip Summary no semver update required Finished [ 90.658s] datafusion-datasource Building datafusion-datasource-csv v54.1.0 (current) Built [ 44.139s] (current) Parsing datafusion-datasource-csv v54.1.0 (current) Parsed [ 0.011s] (current) Building datafusion-datasource-csv v54.1.0 (baseline) Built [ 43.905s] (baseline) Parsing datafusion-datasource-csv v54.1.0 (baseline) Parsed [ 0.012s] (baseline) Checking datafusion-datasource-csv v54.1.0 -> v54.1.0 (no change; assume patch) Checked [ 0.102s] 223 checks: 223 pass, 30 skip Summary no semver update required Finished [ 89.134s] datafusion-datasource-csv Building datafusion-datasource-json v54.1.0 (current) Built [ 43.869s] (current) Parsing datafusion-datasource-json v54.1.0 (current) Parsed [ 0.013s] (current) Building datafusion-datasource-json v54.1.0 (baseline) Built [ 43.309s] (baseline) Parsing datafusion-datasource-json v54.1.0 (baseline) Parsed [ 0.014s] (baseline) Checking datafusion-datasource-json v54.1.0 -> v54.1.0 (no change; assume patch) Checked [ 0.093s] 223 checks: 223 pass, 30 skip Summary no semver update required Finished [ 88.256s] datafusion-datasource-json Building datafusion-datasource-parquet v54.1.0 (current) Built [ 48.782s] (current) Parsing datafusion-datasource-parquet v54.1.0 (current) Parsed [ 0.030s] (current) Building datafusion-datasource-parquet v54.1.0 (baseline) Built [ 49.100s] (baseline) Parsing datafusion-datasource-parquet v54.1.0 (baseline) Parsed [ 0.032s] (baseline) Checking datafusion-datasource-parquet v54.1.0 -> v54.1.0 (no change; assume patch) Checked [ 0.160s] 223 checks: 223 pass, 30 skip Summary no semver update required Finished [ 99.224s] datafusion-datasource-parquet Building datafusion-expr v54.1.0 (current) Built [ 28.675s] (current) Parsing datafusion-expr v54.1.0 (current) Parsed [ 0.076s] (current) Building datafusion-expr v54.1.0 (baseline) Built [ 27.520s] (baseline) Parsing datafusion-expr v54.1.0 (baseline) Parsed [ 0.077s] (baseline) Checking datafusion-expr v54.1.0 -> v54.1.0 (no change; assume patch) Checked [ 1.407s] 223 checks: 223 pass, 30 skip Summary no semver update required Finished [ 58.687s] datafusion-expr Building datafusion-physical-expr v54.1.0 (current) Built [ 29.813s] (current) Parsing datafusion-physical-expr v54.1.0 (current) Parsed [ 0.047s] (current) Building datafusion-physical-expr v54.1.0 (baseline) Built [ 30.190s] (baseline) Parsing datafusion-physical-expr v54.1.0 (baseline) Parsed [ 0.050s] (baseline) Checking datafusion-physical-expr v54.1.0 -> v54.1.0 (no change; assume patch) Checked [ 0.364s] 223 checks: 223 pass, 30 skip Summary no semver update required Finished [ 61.264s] datafusion-physical-expr Building datafusion-physical-expr-common v54.1.0 (current) Built [ 25.112s] (current) Parsing datafusion-physical-expr-common v54.1.0 (current) Parsed [ 0.020s] (current) Building datafusion-physical-expr-common v54.1.0 (baseline) Built [ 24.915s] (baseline) Parsing datafusion-physical-expr-common v54.1.0 (baseline) Parsed [ 0.020s] (baseline) Checking datafusion-physical-expr-common v54.1.0 -> v54.1.0 (no change; assume patch) Checked [ 0.208s] 223 checks: 223 pass, 30 skip Summary no semver update required Finished [ 51.027s] datafusion-physical-expr-common Building datafusion-proto v54.1.0 (current) Built [ 61.118s] (current) Parsing datafusion-proto v54.1.0 (current) Parsed [ 0.017s] (current) Building datafusion-proto v54.1.0 (baseline) Built [ 61.846s] (baseline) Parsing datafusion-proto v54.1.0 (baseline) Parsed [ 0.019s] (baseline) Checking datafusion-proto v54.1.0 -> v54.1.0 (no change; assume patch) Checked [ 0.242s] 223 checks: 220 pass, 3 fail, 0 warn, 30 skip --- failure declarative_macro_missing: macro_rules declaration removed or renamed --- Description: A `macro_rules!` declarative macro cannot be invoked by its prior name. The macro may have been renamed or removed entirely. ref: https://doc.rust-lang.org/reference/macros-by-example.html#path-based-scope impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.49.0/src/lints/declarative_macro_missing.ron Failed in: macro convert_required_proto, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/5a771c5ef589a0448dc9180a70436770ab8dc71b/datafusion/proto/src/common.rs:35 --- failure module_missing: pub module removed or renamed --- Description: A publicly-visible module cannot be imported by its prior path. A `pub use` may have been removed, or the module may have been renamed, removed, or made non-public. ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.49.0/src/lints/module_missing.ron Failed in: mod datafusion_proto::convert, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/5a771c5ef589a0448dc9180a70436770ab8dc71b/datafusion/proto/src/convert.rs:18 --- failure trait_missing: pub trait removed or renamed --- Description: A publicly-visible trait cannot be imported by its prior path. A `pub use` may have been removed, or the trait itself may have been renamed or removed entirely. ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.49.0/src/lints/trait_missing.ron Failed in: trait datafusion_proto::convert::TryFromProto, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/5a771c5ef589a0448dc9180a70436770ab8dc71b/datafusion/proto/src/convert.rs:41 trait datafusion_proto::TryFromProto, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/5a771c5ef589a0448dc9180a70436770ab8dc71b/datafusion/proto/src/convert.rs:41 trait datafusion_proto::convert::FromProto, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/5a771c5ef589a0448dc9180a70436770ab8dc71b/datafusion/proto/src/convert.rs:35 trait datafusion_proto::FromProto, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/5a771c5ef589a0448dc9180a70436770ab8dc71b/datafusion/proto/src/convert.rs:35 Summary semver requires new major version: 3 major and 0 minor checks failed Finished [ 124.505s] datafusion-proto Building datafusion-proto-models v54.1.0 (current) Built [ 25.136s] (current) Parsing datafusion-proto-models v54.1.0 (current) Parsed [ 0.130s] (current) Building datafusion-proto-models v54.1.0 (baseline) Built [ 25.491s] (baseline) Parsing datafusion-proto-models v54.1.0 (baseline) Parsed [ 0.131s] (baseline) Checking datafusion-proto-models v54.1.0 -> v54.1.0 (no change; assume patch) Checked [ 1.826s] 223 checks: 223 pass, 30 skip Summary no semver update required Finished [ 53.723s] datafusion-proto-models ``` </details> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
