akshaychitneni commented on code in PR #2279:
URL:
https://github.com/apache/datafusion-ballista/pull/2279#discussion_r3761616159
##########
ballista/scheduler/src/config.rs:
##########
@@ -399,7 +399,9 @@ impl Default for SchedulerConfig {
grpc_client_max_message_size: 16777216,
executor_timeout_seconds: 180,
expire_dead_executor_interval_seconds: 15,
- no_executors_grace_period_seconds: 30,
+ // Defaults to `executor_timeout_seconds` so the grace is always >=
+ // the executor heartbeat interval (see the field doc).
+ no_executors_grace_period_seconds: 180,
Review Comment:
Yes. 180 is the default executor_timeout_seconds (the liveness window)
giving 3× margin for a transiently-removed executor to re-register before its
jobs fail
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
