2010YOUY01 commented on code in PR #24259:
URL: https://github.com/apache/datafusion/pull/24259#discussion_r3772020445
##########
datafusion/physical-plan/src/aggregates/mod.rs:
##########
@@ -1215,6 +1219,12 @@ impl AggregateExec {
)?));
}
+ if self.should_use_ordered_single_aggregate_stream(context) {
Review Comment:
This is a good point, I've noticed it also. This entire code block can
likely be simplified somehow to be more understandable.
I've opened a issue https://github.com/apache/datafusion/issues/24318, and
I'll try to do it after the refactor is done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
