ulrichurriola-parada-ops commented on PR #24271: URL: https://github.com/apache/datafusion/pull/24271#issuecomment-5277437670
> Im a bit confused by this PR, where is `_build_timer` actually used? The `_build_timer` is not "used" but: * Its instantiation starts the timer (see `Time.timer` impl in `datafusion/physical-expr-common/src/metrics/value.rs`, l.214) * Its deletion (`Drop` in `ScopedTimerGuard`, `datafusion/physical-expr-common/src/metrics/value.rs` l.359) stops the timer and add elapsed time to the inner object: the `metrics.build_time` Note: a similar use exists in the codebase in `datafusion/physical-plan/src/joins/nested_loop_join.rs`, l1271 Thank you for the review -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
