Dandandan commented on code in PR #24326:
URL: https://github.com/apache/datafusion/pull/24326#discussion_r3776807200
##########
datafusion/session/src/table.rs:
##########
@@ -351,25 +353,47 @@ pub trait TableProvider: Any + Debug + Sync + Send {
///
/// Returns an [`ExecutionPlan`] producing a single row with `count`
(UInt64).
/// Empty `filters` deletes all rows.
- async fn delete_from(
- &self,
- _state: &dyn Session,
+ // Compile-time optimization: written as the desugaring of `async fn` so
this
Review Comment:
Yeah agree - perhaps also it would be worth considering getting rid of
`async_trait` and create a ticket for it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
