alamb commented on code in PR #24325:
URL: https://github.com/apache/datafusion/pull/24325#discussion_r3779139554
##########
datafusion/catalog/src/memory/table.rs:
##########
@@ -184,7 +186,95 @@ impl TableProvider for MemTable {
TableType::Base
}
- async fn scan(
+ fn scan<'life0, 'life1, 'life2, 'life3, 'async_trait>(
Review Comment:
This is amazing -- I think it would help future readers if we left some
comments pointing back at an explanation of why this particular implementation
helps compile time
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
