u70b3 commented on code in PR #23987: URL: https://github.com/apache/datafusion/pull/23987#discussion_r3788971463
########## datafusion/spark/src/function/math/modulus.rs: ########## Review Comment: Good call — added coverage for the pmod path in the latest push: - Unit tests mirroring the mod ones: ANSI float `0.0` raises, legacy `-0.0` returns NULL, ANSI `-0.0` raises, and an ANSI NULL dividend with a zero divisor returns NULL without raising (both int and float). - SQLLogic cases in `spark/math/pmod.slt` for the same scenarios. Also rebased onto the latest main. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
