lyne7-sc commented on PR #24391: URL: https://github.com/apache/datafusion/pull/24391#issuecomment-5308084771
Thanks @alamb and @Omega359. The new SQL benchmark framework is very nice to use. Most aggregate benchmarks I found focus on individual accumulator operations such as `update_batch` or `merge_batch`, making it harder to observe an aggregate’s performance and memory behavior across the complete query execution path. I also considered `aggregate_query_sql.rs`, but benchmarking aggregate functions often requires a broad range of workloads and data distributions, and the new SQL benchmark framework seems more flexible for defining and extending those cases. If this direction makes sense, I think we could migrate the other end-to-end aggregate cases into this suite. Alternatively, if there is another existing suite or location that would be a better fit, I’m happy to move these cases there. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
