schenksj commented on PR #4952: URL: https://github.com/apache/datafusion-comet/pull/4952#issuecomment-5332835603
@parthchandra Preflight is fixed and green. The failure was `CometScanContribSuite` not being registered in the PR workflows (Comet requires every suite to be listed) — added to `pr_build_linux.yml` and `pr_build_macos.yml`, verified locally with `dev/ci/check-suites.py`. The build-gate job is green too, and the rest of the matrix is still running. Also rebased onto current `main`. **Could I ask you to re-review before merging?** You raised five follow-up items on the tracking PR (#4366), and three of them are fixed *here in A.2* rather than there, because A.2 is where the code lives: | Your item (raised on #4366) | Change in this PR | |---|---| | 2 — config defaults | `spark.comet.scan.deltaNative.enabled` now defaults to **`false`**; `dataFileConcurrencyLimit` doc reconciled with its default; `cdf.maxPartitions` **removed** from A.2 (it moves to A.5 with CDF) | | 4 — configs missing from generated docs | New core SPI `CometConfigProvider` + a `GenerateDocs` hook | | 5 — noticing two contribs claiming one scan | New internal config `spark.comet.scan.contrib.detectConflicts.enabled` (default off) + the conflict-detecting path in `CometScanContrib` | The contrib-side halves land in later parts (`DeltaConfigProvider` + service file in A.4a, the `cdf.maxPartitions` definition in A.5, the `delta.md` table in A.7), so this PR carries only the core, format-agnostic pieces. Full reasoning for all five is in my reply on #4366. Happy to split any of these out if you'd rather merge exactly what you approved. --- 🤖 This reply was drafted with [Claude Code](https://claude.com/claude-code). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
