unikdahal opened a new pull request, #5412: URL: https://github.com/apache/datafusion-comet/pull/5412
## Which issue does this PR close? Closes #5258. ## Rationale for this change `extractFileLocation`, `getFileFormat`, `getEqualityFieldIds` collapsed "accessor not declared" and "accessor threw" into the same `None`/empty. Live bug: `CometScanRule` reads an empty `getEqualityFieldIds` as "position delete" and goes native, even when the empty was actually a swallowed failure. ## What changes are included in this PR? `Option`/empty now means "not declared" only; genuine invoke failures propagate. Matches `findMethod`'s existing contract, per review comment on the issue. No caller changes needed at `CometScanRule` -- its existing outer catch just starts firing correctly. ## How are these changes tested? New `IcebergReflectionSuite` cases proving failures propagate instead of collapsing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
