sunchao commented on code in PR #24526:
URL: https://github.com/apache/datafusion/pull/24526#discussion_r3859556461
##########
datafusion/datasource-parquet/src/page_filter.rs:
##########
@@ -138,15 +138,25 @@ impl PagePruningResult {
impl PagePruningAccessPlanFilter {
/// Create a new [`PagePruningAccessPlanFilter`] from a physical
- /// expression.
- #[expect(clippy::needless_pass_by_value)]
+ /// expression, using the default `IN (...)` pruning limit.
pub fn new(expr: &Arc<dyn PhysicalExpr>, schema: SchemaRef) -> Self {
+ Self::new_with_max_in_list_size(expr, schema, MAX_IN_LIST_SIZE)
+ }
+
+ /// Create a page filter using the same `IN (...)` limit as row-group
pruning.
+ #[expect(clippy::needless_pass_by_value)]
Review Comment:
Addressed in
[df65b7c](https://github.com/apache/datafusion/pull/24526/commits/df65b7cc0c17913f1aa084318bcf9be5ccb06a5d).
`new_with_max_in_list_size` now takes `&SchemaRef`, and the opener passes its
existing reference. The public `new` signature is unchanged.
I also added the agreed ordering, single-bound, and threshold comments.
Formatting, full all-targets/all-features Clippy with warnings denied, and
`./dev/rust_lint.sh` passed, as did 10,796 Rust tests (8 ignored) and all 505
SQL logic files. The extended rerun used a 65,536 open-file limit after the
initial run hit the environment's 1,024 limit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
