sunchao commented on PR #5051: URL: https://github.com/apache/datafusion-comet/pull/5051#issuecomment-5448373191
> @viirya @sunchao happy either way — say which you would rather review and I will restructure, or leave it as is if folding it in here is fine. Thanks @andygrove , that makes sense. I'm in favor of splitting the broadcast fix into its own PR under #5510, since it affects existing native broadcast joins without the cache feature. The shared registrations, registrator, startup warning, and a broadcast regression test can land there first, with #5051 keeping the cache-specific registrations and tests. That lets us fix the existing bug independently and keeps this PR focused. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
