0lai0 commented on PR #5367: URL: https://github.com/apache/datafusion-comet/pull/5367#issuecomment-5454714800
Thanks @andygrove for review, all three addressed: 1. **`benches/spark_pow.rs`** pipeline now includes both `pow(a + 2.5D, 3)` (array/scalar dispatch) and `pow(a + 2.5D, b)` (array/array dispatch) with a non-null array of fractional exponents so the `powf` work stays measurable. Timing wraps the `add` + `spark_pow` composition, not a pre-materialised intermediate. 2. **`array_insert.rs`** reworded the `is_not_null` comment to state the forward-looking length invariant (`into_array(batch.num_rows())` broadcasts scalars, so the mask matches batch length; without it downstream `and`/`evaluate_selection` would fail on length mismatch). 3. **`pow.rs` / `CometExpressionSuite.scala`** the null-scalar short-circuit doc and `test_spark_pow_null_scalar` both cover null on either side; Scala regression test uses `checkSparkAnswerAndOperator`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
