milenkovicm commented on code in PR #2387:
URL:
https://github.com/apache/datafusion-ballista/pull/2387#discussion_r3890274556
##########
ballista/core/src/config.rs:
##########
@@ -746,8 +752,8 @@ impl BallistaConfig {
/// Returns the target post-coalesce partition byte size in bytes
/// (Spark's `advisoryPartitionSizeInBytes`).
- pub fn coalesce_target_partition_bytes(&self) -> u64 {
- self.get_usize_setting(BALLISTA_COALESCE_TARGET_PARTITION_BYTES) as u64
+ pub fn coalesce_target_partition_bytes(&self) -> usize {
Review Comment:
if we revert it to previous we would have `usize as u64` then in the other
method we'd have `u64 to usize`. maybe we should avoid using usize and use u64
everywhere, we can change it now as one big break?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
