adamreeve opened a new pull request, #24866: URL: https://github.com/apache/datafusion/pull/24866
## Which issue does this PR close? - Closes #21634. ## Rationale for this change Previously an error when retrieving the footer key was used as an indication that a key retriever was used, but this isn't reliable. A key retriever implementation might choose to return a footer key even if no key metadata is provided. This could mean that a footer key is set in the converted decryption properties but column keys are not correctly converted. arrow-rs didn't previously expose whether a key retriever is used, but this was added in 59.0.0. ## What changes are included in this PR? Use the new `FileDecryptionProperties::uses_key_retriever` to determine whether `FileDecryptionProperties` uses a key retriever, rather than rely on getting an error when getting the footer key. ## What is the testing strategy for this PR? Updated existing unit test. ## Are there any user-facing changes? No, this changes an error message but should otherwise not affect users except if they had a key retriever implementation that would return footer keys without any metadata being provided. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
