github-actions[bot] commented on PR #24484:
URL: https://github.com/apache/datafusion/pull/24484#issuecomment-5503665469

   <!-- semver-check-comment -->
   Thank you for opening this pull request!
   
   Reviewer note: 
[cargo-semver-checks](https://github.com/obi1kenobi/cargo-semver-checks) 
reported the current version number is not SemVer-compatible with the changes 
in this pull request (compared against the base branch).
   
   <details>
   <summary>Details</summary>
   
   ```
        Cloning apache/main
       Building datafusion-physical-expr v55.0.0 (current)
          Built [  39.123s] (current)
        Parsing datafusion-physical-expr v55.0.0 (current)
         Parsed [   0.050s] (current)
       Building datafusion-physical-expr v55.0.0 (baseline)
          Built [  31.195s] (baseline)
        Parsing datafusion-physical-expr v55.0.0 (baseline)
         Parsed [   0.050s] (baseline)
       Checking datafusion-physical-expr v55.0.0 -> v55.0.0 (no change; assume 
patch)
        Checked [   0.341s] 223 checks: 220 pass, 3 fail, 0 warn, 31 skip
   
   --- failure derive_trait_impl_removed: built-in derived trait no longer 
implemented ---
   
   Description:
   A public type has stopped deriving one or more traits. This can break 
downstream code that depends on those types implementing those traits.
           ref: 
https://doc.rust-lang.org/reference/attributes/derive.html#derive
          impl: 
https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.50.0/src/lints/derive_trait_impl_removed.ron
   
   Failed in:
     type TryCastExpr no longer derives Clone, in 
/home/runner/work/datafusion/datafusion/datafusion/physical-expr/src/expressions/try_cast.rs:34
   
   --- failure function_missing: pub fn removed or renamed ---
   
   Description:
   A publicly-visible function cannot be imported by its prior path. A `pub 
use` may have been removed, or the function itself may have been renamed or 
removed entirely.
           ref: 
https://doc.rust-lang.org/cargo/reference/semver.html#item-remove
          impl: 
https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.50.0/src/lints/function_missing.ron
   
   Failed in:
     function 
datafusion_physical_expr::expressions::try_cast_with_target_field, previously 
in file 
/home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/465c32999df67c977c2c553cdde2196f0ff0adac/datafusion/physical-expr/src/expressions/try_cast.rs:298
   
   --- failure inherent_method_missing: pub method removed or renamed ---
   
   Description:
   A publicly-visible method or associated fn is no longer available under its 
prior name. It may have been renamed or removed entirely.
           ref: 
https://doc.rust-lang.org/cargo/reference/semver.html#item-remove
          impl: 
https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.50.0/src/lints/inherent_method_missing.ron
   
   Failed in:
     CastExpr::target_metadata, previously in file 
/home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/465c32999df67c977c2c553cdde2196f0ff0adac/datafusion/physical-expr/src/expressions/cast.rs:171
     CastExpr::target_nullable, previously in file 
/home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/465c32999df67c977c2c553cdde2196f0ff0adac/datafusion/physical-expr/src/expressions/cast.rs:176
     CastExpr::has_explicit_metadata, previously in file 
/home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/465c32999df67c977c2c553cdde2196f0ff0adac/datafusion/physical-expr/src/expressions/cast.rs:204
     CastExpr::has_explicit_nullability, previously in file 
/home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/465c32999df67c977c2c553cdde2196f0ff0adac/datafusion/physical-expr/src/expressions/cast.rs:209
     TryCastExpr::new_with_target_field, previously in file 
/home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/465c32999df67c977c2c553cdde2196f0ff0adac/datafusion/physical-expr/src/expressions/try_cast.rs:105
     TryCastExpr::target_metadata, previously in file 
/home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/465c32999df67c977c2c553cdde2196f0ff0adac/datafusion/physical-expr/src/expressions/try_cast.rs:127
     TryCastExpr::target_field, previously in file 
/home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/465c32999df67c977c2c553cdde2196f0ff0adac/datafusion/physical-expr/src/expressions/try_cast.rs:136
   
        Summary semver requires new major version: 3 major and 0 minor checks 
failed
       Finished [  71.846s] datafusion-physical-expr
   ```
   
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to