2010YOUY01 commented on code in PR #24870:
URL: https://github.com/apache/datafusion/pull/24870#discussion_r3912609532
##########
datafusion/physical-plan/src/aggregates/mod.rs:
##########
@@ -3519,12 +3525,14 @@ mod tests {
| 2 | 1.0 | 0 | 1 |
| 3 | | 1 | 1 |
| 3 | | 1 | 2 |
- | 3 | 2.0 | 0 | 2 |
+ | 3 | 2.0 | 0 | 1 |
Review Comment:
Both are valid outputs for partial aggregation with early emit; the
difference is because execution is not 100% the same between the legacy and
refactored implementations.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
