dwsmith1983 commented on code in PR #5568:
URL: https://github.com/apache/datafusion-comet/pull/5568#discussion_r3913216574
##########
native/shuffle/src/writers/local/local_partition_writer.rs:
##########
@@ -243,9 +260,18 @@ impl PartitionWriter for LocalPartitionWriter {
);
for batch in iter.by_ref() {
let batch = batch?;
- buf_batch_writer.write(&batch, &metrics.encode_time,
&metrics.write_time)?;
+ buf_batch_writer.write(
Review Comment:
Good catch, this one is on me too. Both call sites now bind the loop and
flush to a result and clear the scratch before propagating, so an errored
partition always hands back an empty buffer. Added a failing test at each site
first; they showed 1244 retained bytes and now come back empty.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
